Re: [PATCH v2 11/44] aha1542: Remove a set-but-not-used array

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 




> On Feb 8, 2022, at 9:24 AM, Bart Van Assche <bvanassche@xxxxxxx> wrote:
> 
> This patch fixes the following W=1 warning:
> 
> drivers/scsi/aha1542.c:209:12: warning: variable ‘inquiry_result’ set but not used [-Wunused-but-set-variable]
>  209 |         u8 inquiry_result[4];
> 
> Reviewed-by: Johannes Thumshirn <johannes.thumshirn@xxxxxxx>
> Signed-off-by: Bart Van Assche <bvanassche@xxxxxxx>
> ---
> drivers/scsi/aha1542.c | 3 +--
> 1 file changed, 1 insertion(+), 2 deletions(-)
> 
> diff --git a/drivers/scsi/aha1542.c b/drivers/scsi/aha1542.c
> index f0e8ae9f5e40..cf7bba2ca68d 100644
> --- a/drivers/scsi/aha1542.c
> +++ b/drivers/scsi/aha1542.c
> @@ -206,7 +206,6 @@ static int makecode(unsigned hosterr, unsigned scsierr)
> 
> static int aha1542_test_port(struct Scsi_Host *sh)
> {
> -	u8 inquiry_result[4];
> 	int i;
> 
> 	/* Quick and dirty test for presence of the card. */
> @@ -240,7 +239,7 @@ static int aha1542_test_port(struct Scsi_Host *sh)
> 	for (i = 0; i < 4; i++) {
> 		if (!wait_mask(STATUS(sh->io_port), DF, DF, 0, 0))
> 			return 0;
> -		inquiry_result[i] = inb(DATA(sh->io_port));
> +		(void)inb(DATA(sh->io_port));
> 	}
> 
> 	/* Reading port should reset DF */

Reviewed-by: Himanshu Madhani <himanshu.madhani@xxxxxxxxxx>

--
Himanshu Madhani	 Oracle Linux Engineering





[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
[Index of Archives]     [SCSI Target Devel]     [Linux SCSI Target Infrastructure]     [Kernel Newbies]     [IDE]     [Security]     [Git]     [Netfilter]     [Bugtraq]     [Yosemite News]     [MIPS Linux]     [ARM Linux]     [Linux Security]     [Linux RAID]     [Linux ATA RAID]     [Linux IIO]     [Samba]     [Device Mapper]

  Powered by Linux