On 09/02/2022 00:04, Bart Van Assche wrote:
diff --git a/drivers/scsi/ips.c b/drivers/scsi/ips.c
index 498bf04499ce..b3532d290848 100644
--- a/drivers/scsi/ips.c
+++ b/drivers/scsi/ips.c
@@ -655,13 +655,13 @@ ips_release(struct Scsi_Host *sh)
This function and other places return an int, and not a bool, so that
could be changed as well. Prob not worth the churn, though.
Because of this comment I took a closer look at the ips_release()
function. It seems to me that that function only has one caller and that
caller ignores the value returned by ips_release(). So how about
changing the return type into 'void'?
You could do that. But then there are other places where FALSE is
checked against at uint8_t - see ips_ha.waitflag, so by the same reason
could be changed.
However, as I said, changes like this are prob not worth it...
thanks,
John
