Re: [PATCH v2 01/44] ips: Use true and false instead of TRUE and FALSE

[John Garry <john.garry@xxxxxxxxxx>]

On 08/02/2022 17:24, Bart Van Assche wrote:
> This patch prepares for removal of the drivers/scsi/scsi.h header file.
> That header file defines the 'TRUE' and 'FALSE' constants.
>
> Reviewed-by: Johannes Thumshirn<johannes.thumshirn@xxxxxxx>
> Signed-off-by: Bart Van Assche<bvanassche@xxxxxxx>

Regardless of comment, below, feel free to add:

Reviewed-by: John Garry <john.garry@xxxxxxxxxx>

> ---
>   drivers/scsi/ips.c | 42 ++++++++++++++++++++----------------------
>   1 file changed, 20 insertions(+), 22 deletions(-)
>
> diff --git a/drivers/scsi/ips.c b/drivers/scsi/ips.c
> index 498bf04499ce..b3532d290848 100644
> --- a/drivers/scsi/ips.c
> +++ b/drivers/scsi/ips.c
> @@ -655,13 +655,13 @@ ips_release(struct Scsi_Host *sh)

This function and other places return an int, and not a bool, so that 
could be changed as well. Prob not worth the churn, though.

>   		printk(KERN_WARNING
>   		       "(%s) release, invalid Scsi_Host pointer.\n", ips_name);
>   		BUG();
> -		return (FALSE);
> +		return false;
>   	}
>   
>   	ha = IPS_HA(sh);
>   
>   	if (!ha)
> -		return (FALSE);
> +		return false;
>   
>   	/* flush the cache on the controller */
>   	scb = &ha->scbs[ha->max_cmds - 1];
> @@ -700,7 +700,7 @@ ips_release(struct Scsi_Host *sh)
>   
>   	ips_released_controllers++;
>   
> -	return (FALSE);
> +	return false;