On Mon, 2022-01-31 at 09:19 -0800, Bart Van Assche wrote: > On 1/31/22 02:39, Johannes Thumshirn wrote: > > On Fri, 2022-01-28 at 14:18 -0800, Bart Van Assche wrote: > > > > > + wq = bfad_priv(cmnd)->wq; > > > + bfad_priv(cmnd)->wq = NULL; > > > > Can't this be shortened to > > > > wq = xhcg(bfad_priv(cmnd)->wq, NULL); > > In this patch series my goal was to introduce as few functional > changes > as possible in legacy drivers. The xchg() alternative looks valid to > me > but would involve a functional change, namely changing non-atomic > instructions into an atomic instruction. Do you want me to make that > change? Up to you. You're completely right in that it's a functional change (atomic vs non-atomic) and I've only concentrated on the compactness of the code here.
