Re: [PATCH 13/44] bfa: Stop using the SCSI pointer

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On 1/31/22 02:39, Johannes Thumshirn wrote:
On Fri, 2022-01-28 at 14:18 -0800, Bart Van Assche wrote:

+       wq = bfad_priv(cmnd)->wq;
+       bfad_priv(cmnd)->wq = NULL;

Can't this be shortened to
wq = xhcg(bfad_priv(cmnd)->wq, NULL);

In this patch series my goal was to introduce as few functional changes as possible in legacy drivers. The xchg() alternative looks valid to me but would involve a functional change, namely changing non-atomic instructions into an atomic instruction. Do you want me to make that change?

Thanks,

Bart.



[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
[Index of Archives]     [SCSI Target Devel]     [Linux SCSI Target Infrastructure]     [Kernel Newbies]     [IDE]     [Security]     [Git]     [Netfilter]     [Bugtraq]     [Yosemite News]     [MIPS Linux]     [ARM Linux]     [Linux Security]     [Linux RAID]     [Linux ATA RAID]     [Linux IIO]     [Samba]     [Device Mapper]

  Powered by Linux