Hi Himanshu, > -----Original Message----- > From: Himanshu Madhani <himanshu.madhani@xxxxxxxxxx> > Sent: Wednesday, January 5, 2022 7:26 AM > To: Daniel Wagner <dwagner@xxxxxxx> > Cc: Saurav Kashyap <skashyap@xxxxxxxxxxx>; Nilesh Javali > <njavali@xxxxxxxxxxx>; Martin Petersen <martin.petersen@xxxxxxxxxx>; > linux-scsi@xxxxxxxxxxxxxxx; GR-QLogic-Storage-Upstream <GR-QLogic-Storage- > Upstream@xxxxxxxxxxx>; Sebastian Andrzej Siewior <bigeasy@xxxxxxxxxxxxx> > Subject: [EXT] Re: [PATCH 02/16] qla2xxx: Implement ref count for srb > > External Email > > ---------------------------------------------------------------------- > > > > On Jan 4, 2022, at 4:32 AM, Daniel Wagner <dwagner@xxxxxxx> wrote: > > > > On Mon, Jan 03, 2022 at 03:56:06AM +0000, Saurav Kashyap wrote: > >>>> - sp->free(sp); > >>>> + /* ref: INIT */ > >>> > >>> IMO, There is no need for this comment spread in this patch. Please explain > If > >>> you think there is need for comment. > >> > >> <SK> Thanks for the review. The sp reference can be taken and released on > various paths. These comments make > >> life simpler during some ref issue and also make code more understandable. > For various scenarios, this comments > >> helps in determining final reference count and check if its released properly > or not. > > > > I think the better way to address is to get Sebastian's patch working: > > > > https://urldefense.proofpoint.com/v2/url?u=https- > 3A__lore.kernel.org_all_20131103193308.GA20998- > 40linutronix.de_&d=DwIFAg&c=nKjWec2b6R0mOyPaz7xtfQ&r=ZHZbmY_LbM3 > DUZK_BDO1OITP3ot_Vkb_5w- > gas5TBMQ&m=pgQzCrwTlIOgowou6VpA1Ntie8bnWsKW6idQUvbA_vrFvKwgX- > Nh8y6xHCE6ek37&s=6cEa2Qr6Pg9kxgvIV7vOvya2xWBK39Zr5XJygiIk5vw&e= > > > > Daniel > > This patch would be good to get it working for debugging reference counter. > However, for the current series, I am okay with this patch if better > description is provided for the comment. Thanks for review, will update the description. Thanks, ~Saurav > > -- > Himanshu Madhani Oracle Linux Engineering
