> On Jan 4, 2022, at 4:32 AM, Daniel Wagner <dwagner@xxxxxxx> wrote: > > On Mon, Jan 03, 2022 at 03:56:06AM +0000, Saurav Kashyap wrote: >>>> - sp->free(sp); >>>> + /* ref: INIT */ >>> >>> IMO, There is no need for this comment spread in this patch. Please explain If >>> you think there is need for comment. >> >> <SK> Thanks for the review. The sp reference can be taken and released on various paths. These comments make >> life simpler during some ref issue and also make code more understandable. For various scenarios, this comments >> helps in determining final reference count and check if its released properly or not. > > I think the better way to address is to get Sebastian's patch working: > > https://lore.kernel.org/all/20131103193308.GA20998@xxxxxxxxxxxxx/ > > Daniel This patch would be good to get it working for debugging reference counter. However, for the current series, I am okay with this patch if better description is provided for the comment. -- Himanshu Madhani Oracle Linux Engineering
