> On Dec 23, 2021, at 11:07 PM, Nilesh Javali <njavali@xxxxxxxxxxx> wrote:
>
> The smatch reports warning message,
> drivers/scsi/qla2xxx/qla_target.c:3324 qlt_xmit_response() warn: missing error
> code 'res'
>
> Cc: stable@xxxxxxxxxxxxxxx
> Fixes: 4a8f71014b4d ("scsi: qla2xxx: Fix unmap of already freed sgl")
> Signed-off-by: Nilesh Javali <njavali@xxxxxxxxxxx>
> ---
> drivers/scsi/qla2xxx/qla_target.c | 1 +
> 1 file changed, 1 insertion(+)
>
> diff --git a/drivers/scsi/qla2xxx/qla_target.c b/drivers/scsi/qla2xxx/qla_target.c
> index b0990f2ee91c..feb054c688a3 100644
> --- a/drivers/scsi/qla2xxx/qla_target.c
> +++ b/drivers/scsi/qla2xxx/qla_target.c
> @@ -3318,6 +3318,7 @@ int qlt_xmit_response(struct qla_tgt_cmd *cmd, int xmit_type,
> "RESET-RSP online/active/old-count/new-count = %d/%d/%d/%d.\n",
> vha->flags.online, qla2x00_reset_active(vha),
> cmd->reset_count, qpair->chip_reset);
> + res = 0;
> goto out_unmap_unlock;
> }
>
> --
> 2.23.1
>
Reviewed-by: Himanshu Madhani <himanshu.madhani@xxxxxxxxxx>
--
Himanshu Madhani Oracle Linux Engineering
