On Sat, 2007-05-26 at 18:27 -0600, Matthew Wilcox wrote: > On Sat, May 26, 2007 at 07:15:43PM -0500, James Bottomley wrote: > > Actually, it's a thinko on my part ... I thought late_initcall() and > > module_init() are the same level, and hence this would be link order > > dependent. Actually that's only true in the modular case, so the patch > > is fine ... I'll put it in. > > I disagree that Grant's patch is fine. Consider: > > - CONFIG_SCSI=y > - CONFIG_SCSI_SYM2=y > - CONFIG_SCSI_QLA2XYZ=m > > You want the root disc on your sym2 to be found, so you need > SCSI_WAIT_SCAN=y, but you also want to know when qla2xyz has finished > scanning the fabric, so you need SCSI_WAIT_SCAN=m. My patch doesn't > have this problem. Er .. I think you misunderstood the email. Grant asked why Hugh's (not Grant's) patch was wrong and I said that on reflection it wasn't. James - To unsubscribe from this list: send the line "unsubscribe linux-scsi" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
