On Wed, 9 May 2007 22:09:52 -0700 Andrew Morton wrote: > On Wed, 9 May 2007 16:38:09 -0700 Kristen Carlson Accardi <kristen.c.accardi@xxxxxxxxx> wrote: > > > /** > > + * ata_dev_set_AN - Issue SET FEATURES - SATA FEATURES > > + * with sector count set to indicate > > + * Asynchronous Notification feature > > I think kenreldoc requires that all this be on a single line? Correct. > > + * @dev: Device to which command will be sent > > + * > > + * Issue SET FEATURES - SATA FEATURES command to device @dev > > + * on port @ap. > > + * > > + * LOCKING: > > + * PCI/etc. bus probe sem. > > + * > > + * RETURNS: > > + * 0 on success, AC_ERR_* mask otherwise. > > + */ > > ooh, locking and return value documentation. Often missed, and nice. --- ~Randy *** Remember to use Documentation/SubmitChecklist when testing your code *** - To unsubscribe from this list: send the line "unsubscribe linux-scsi" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html