On Thu, 10 May 2007 01:14:38 -0400 Jeff Garzik <jeff@xxxxxxxxxx> wrote: > Andrew Morton wrote: > >> + * @dev: Device to which command will be sent > >> + * > >> + * Issue SET FEATURES - SATA FEATURES command to device @dev > >> + * on port @ap. > >> + * > >> + * LOCKING: > >> + * PCI/etc. bus probe sem. > >> + * > >> + * RETURNS: > >> + * 0 on success, AC_ERR_* mask otherwise. > >> + */ > > > > ooh, locking and return value documentation. Often missed, and nice. > > > We set high standards in the libata world ;-) > It seems to be working. This series is perhaps the most idiomatic and generally kernelly-looking code I've seen in ages. Who cares if it works? ;) - To unsubscribe from this list: send the line "unsubscribe linux-scsi" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
