On 8/6/21 1:11 PM, Damien Le Moal wrote: > Introduce the helper functions ata_dev_config_lba() and > ata_dev_config_chs() to configure the addressing capabilities of a > device. To control message printing in these new helpers, as well as > in ata_dev_configure() and in ata_hpa_resize(), add the helper function > ata_dev_print_info() to avoid open coding for the eh context > ATA_EHI_PRINTINFO flag in multiple functions. > > Signed-off-by: Damien Le Moal <damien.lemoal@xxxxxxx> > --- > drivers/ata/libata-core.c | 131 ++++++++++++++++++++++---------------- > 1 file changed, 75 insertions(+), 56 deletions(-) > Much better. Reviewed-by: Hannes Reinecke <hare@xxxxxxx> Cheers, Hannes -- Dr. Hannes Reinecke Kernel Storage Architect hare@xxxxxxx +49 911 74053 688 SUSE Software Solutions Germany GmbH, Maxfeldstr. 5, 90409 Nürnberg HRB 36809 (AG Nürnberg), GF: Felix Imendörffer