On Thu, Jul 22, 2021 at 02:06:40PM -0400, Martin K. Petersen wrote: > > +static int blk_fill_sghdr_rq(struct request_queue *q, struct request *rq, > > + struct sg_io_hdr *hdr, fmode_t mode) > > [...] > > > +static int blk_complete_sghdr_rq(struct request *rq, struct sg_io_hdr *hdr, > > + struct bio *bio) > > +{ > > Another couple of peculiar naming vestiges. These probably shouldn't > have a "blk_" prefix now that they are under SCSI. Since they are > internal to scsi_ioctl.c I propose you either drop the prefix completely > or make it "scsi_". Ok. I'll keep __blk_send_generic and its callers for now as they'll get removed later in the series.