On Thu, Jul 22, 2021 at 10:47:35AM -0700, Bart Van Assche wrote: > The first time I encountered this function it was not clear to me what the > purpose of this function is. I think this is a good time to add a comment > above this function that explains its purpose, namely to prevent that > unprivileged SG I/O users can modify storage device firmware. Or generally do unexpected things, yes. I'll add a patch at the end of the series to avoid the pain of adding a comment first and then moving the whole code around.