On Fri, 4 May 2007, Andrew Morton wrote: > > Please be careful to add the appropriate cc's. > > On Mon, 30 Apr 2007 04:37:22 -0400 (EDT) "Robert P. J. Day" <rpjday@xxxxxxxxxxxxxx> wrote: > > > > > Remove the apparently redundant GFP_KERNEL type flag in the call to > > kmalloc(). > > > > Signed-off-by: Robert P. J. Day <rpjday@xxxxxxxxxxxxxx> > > > > --- > > > > diff --git a/drivers/scsi/aic7xxx_old.c b/drivers/scsi/aic7xxx_old.c > > index a988d5a..765ded0 100644 > > --- a/drivers/scsi/aic7xxx_old.c > > +++ b/drivers/scsi/aic7xxx_old.c > > @@ -6581,7 +6581,7 @@ aic7xxx_slave_alloc(struct scsi_device *SDptr) > > struct aic7xxx_host *p = (struct aic7xxx_host *)SDptr->host->hostdata; > > struct aic_dev_data *aic_dev; > > > > - aic_dev = kmalloc(sizeof(struct aic_dev_data), GFP_ATOMIC | GFP_KERNEL); > > + aic_dev = kmalloc(sizeof(struct aic_dev_data), GFP_ATOMIC); > > No, this converts the allocation from a robust one which can sleep into a > flakey one which cannot. ... snip ... at this point, i'd be happier to leave the appropriate patches in the hands of those who have a better handle on this. as i posted earlier, there's only two examples of this in the entire tree: drivers/scsi/aic7xxx_old.c: aic_dev = kmalloc(sizeof(struct aic_dev_data), GFP_ATOMIC | GFP_KERNEL); drivers/message/i2o/device.c: resblk = kmalloc(buflen + 8, GFP_KERNEL | GFP_ATOMIC); it's all yours. rday -- ======================================================================== Robert P. J. Day Linux Consulting, Training and Annoying Kernel Pedantry Waterloo, Ontario, CANADA http://fsdev.net/wiki/index.php?title=Main_Page ======================================================================== - To unsubscribe from this list: send the line "unsubscribe linux-scsi" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
