On 09/06/2021 13:01, Yufen Yu wrote:
Do we also need to modify aix79xx in a similar fashion?
There is no aix79xx in directory drivers/scsi. I guess you mean
aic79xxx? But it seems not need to modify.
So if you think that this HBA does not support SATA, then it would be
good to mention it in the commit log.
Some more comments:
On 09/06/2021 10:36, Yufen Yu wrote:
> We found that offline a ata device on hisi sas control and then
/s/ata/SATA/
> scanning the host can probe 255 not exist devices into system.
"can probe 255 non-existant"
> It can be reproduced easily as following:
>
> Some ata devices on hisi sas v3 control:
I don't know what this means, so please drop it.
> [root@localhost ~]# lsscsi
> [2:0:0:0] disk ATA Samsung SSD 860 2B6Q /dev/sda
> [2:0:1:0] disk ATA WDC WD2003FYYS-3 1D01 /dev/sdb
> [2:0:2:0] disk SEAGATE ST600MM0006 B001 /dev/sdc
>
> 1) echo "offline" > /sys/block/sdb/device/state
> 2) echo "- - -" > /sys/class/scsi_host/host2/scan
>
> Then, we can see another 255 not exist devices in system:
use "non-existant"
> [root@localhost ~]# lsscsi
> [2:0:0:0] disk ATA Samsung SSD 860 2B6Q /dev/sda
> [2:0:1:0] disk ATA WDC WD2003FYYS-3 1D01 /dev/sdb
> [2:0:1:1] disk ATA WDC WD2003FYYS-3 1D01 /dev/sdh
> ...
> [2:0:1:255] disk ATA WDC WD2003FYYS-3 1D01 /dev/sdjb
>
> After REPORT LUN command issued to the offline device fail, it tries
> to do a sequential scan and probe all devices whose lun is not 0
> successfully.
>
> To fix the problem, we try to do same things as commit 2fc62e2ac350
> ("[SCSI] libsas: disable scanning lun > 0 on ata devices"), which
> will prevent the device whose lun number is not zero probe into system.
>
Thanks,
John
