hi, John On 2021/6/9 17:40, John Garry wrote:
On 09/06/2021 10:36, Yufen Yu wrote:We found that offline a ata device on hisi sas control and then scanning the host can probe 255 not exist devices into system. It can be reproduced easily as following: Some ata devices on hisi sas v3 control: [root@localhost ~]# lsscsi [2:0:0:0] disk ATA Samsung SSD 860 2B6Q /dev/sda [2:0:1:0] disk ATA WDC WD2003FYYS-3 1D01 /dev/sdb [2:0:2:0] disk SEAGATE ST600MM0006 B001 /dev/sdc 1) echo "offline" > /sys/block/sdb/device/state 2) echo "- - -" > /sys/class/scsi_host/host2/scan Then, we can see another 255 not exist devices in system: [root@localhost ~]# lsscsi [2:0:0:0] disk ATA Samsung SSD 860 2B6Q /dev/sda [2:0:1:0] disk ATA WDC WD2003FYYS-3 1D01 /dev/sdb [2:0:1:1] disk ATA WDC WD2003FYYS-3 1D01 /dev/sdh ... [2:0:1:255] disk ATA WDC WD2003FYYS-3 1D01 /dev/sdjb After REPORT LUN command issued to the offline device fail, it tries to do a sequential scan and probe all devices whose lun is not 0 successfully. To fix the problem, we try to do same things as commit 2fc62e2ac350 ("[SCSI] libsas: disable scanning lun > 0 on ata devices"), which will prevent the device whose lun number is not zero probe into system. Reported-by: Wu Bo <wubo40@xxxxxxxxxx> Suggested-by: John Garry <john.garry@xxxxxxxxxx> Signed-off-by: Yufen Yu <yuyufen@xxxxxxxxxx> --- drivers/scsi/aic94xx/aic94xx_init.c | 1 + drivers/scsi/hisi_sas/hisi_sas_v1_hw.c | 1 + drivers/scsi/hisi_sas/hisi_sas_v2_hw.c | 1 + drivers/scsi/hisi_sas/hisi_sas_v3_hw.c | 1 + drivers/scsi/isci/init.c | 1 + drivers/scsi/libsas/sas_scsi_host.c | 9 +++++++++ drivers/scsi/mvsas/mv_init.c | 1 + drivers/scsi/pm8001/pm8001_init.c | 1 +Do we also need to modify aix79xx in a similar fashion?
There is no aix79xx in directory drivers/scsi. I guess you mean aic79xxx? But it seems not need to modify.
I just noticed that libsas.h already has a prototype for sas_slave_alloc() - any idea why?
'git log' shows that commit fa1c1e8f1ece "[SCSI] Add SATA support to libsas" have introduced sas_slave_alloc. And commit 9508a66f898d "[SCSI] libsas: async ata scanning" delete it while forgetting to get rid of the prototype. Yufen, Thanks
