Re: [PATCH v5 01/24] mpi3mr: add mpi30 Rev-R headers and Kconfig

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



> +	help
> +	This driver supports Broadcom's Unified MPI3 based Storage & RAID Controllers.

Overly long line here.

> +#ifndef MPI30_API_H
> +#define MPI30_API_H     1
> +#include "mpi30_transport.h"
> +#include "mpi30_image.h"
> +#include "mpi30_init.h"
> +#include "mpi30_ioc.h"
> +#endif

Just including the four headers where needed directly would make more
sense to me than this meta-header.

> + *           Name: mpi30_image.h

We generally do not add comments like this.  It does not add any value
and gets stale very quickly.

> + *  Creation Date: 04/02/2018
> + *        Version: 03.00.00

No need for this information either.  If you important from a specific
internal version this is something that should go into the commit log.

> +struct _mpi3_comp_image_version {

Please drop the leading underscore from the various type names.



[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
[Index of Archives]     [SCSI Target Devel]     [Linux SCSI Target Infrastructure]     [Kernel Newbies]     [IDE]     [Security]     [Git]     [Netfilter]     [Bugtraq]     [Yosemite News]     [MIPS Linux]     [ARM Linux]     [Linux Security]     [Linux RAID]     [Linux ATA RAID]     [Linux IIO]     [Samba]     [Device Mapper]

  Powered by Linux