Re: [PATCH v3 6/8] qla2xxx: Use scsi_get_sector() instead of scsi_get_lba()

[Bart Van Assche <bvanassche@xxxxxxx>]

On 5/13/21 7:02 PM, Damien Le Moal wrote:
> On 2021/05/14 7:38, Bart Van Assche wrote:
>> @@ -2677,7 +2677,7 @@ qla2x00_handle_dif_error(srb_t *sp, struct sts_entry_24xx *sts24)
>>  			if (k != blocks_done) {
>>  				ql_log(ql_log_warn, vha, 0x302f,
>>  				    "unexpected tag values tag:lba=%x:%llx)\n",
>> -				    e_ref_tag, (unsigned long long)lba_s);
>> +				    e_ref_tag, (u64)sector);
>>  				return 1;
>>  			}
>>  
>>
> 
> Not entirely convinced the casts are needed for the log calls...
> Apart from that, looks good.
> 
> Reviewed-by: Damien Le Moal <damien.lemoal@xxxxxxx>

Hi Damien,

I will remove the cast from the ql_log() call.

Thanks,

Bart.