On 5/13/21 7:00 PM, Damien Le Moal wrote:
> On 2021/05/14 7:38, Bart Van Assche wrote:
>> diff --git a/drivers/scsi/lpfc/lpfc_scsi.c b/drivers/scsi/lpfc/lpfc_scsi.c
>> index eefbb9b22798..8c6b25807f12 100644
>> --- a/drivers/scsi/lpfc/lpfc_scsi.c
>> +++ b/drivers/scsi/lpfc/lpfc_scsi.c
>> @@ -2963,7 +2963,7 @@ lpfc_sli4_parse_bg_err(struct lpfc_hba *phba, struct lpfc_io_buf *lpfc_cmd,
>> "9059 BLKGRD: Guard Tag error in cmd"
>> " 0x%x lba 0x%llx blk cnt 0x%x "
>> "bgstat=x%x bghm=x%x\n", cmd->cmnd[0],
>> - (unsigned long long)scsi_get_lba(cmd),
>> + (u64)scsi_get_sector(cmd),
>
> Why the cast ? scsi_get_sector() returns a 64bits sector_t.
Right, the cast can be left out. Commit 72deb455b5ec ("block: remove
CONFIG_LBDAF") changed sector_t from sometimes 32-bit / sometimes 64-bit
into always 64-bit.
Bart.
