On 4/26/21 5:26 PM, Christoph Hellwig wrote:
On Fri, Apr 23, 2021 at 01:39:24PM +0200, Hannes Reinecke wrote:
Make ql_pcmd() a void function and set the SCSI result directly.
Signed-off-by: Hannes Reinecke <hare@xxxxxxx>
---
drivers/scsi/qlogicfas408.c | 75 ++++++++++++++++++++++++-------------
1 file changed, 49 insertions(+), 26 deletions(-)
Can you explain why this is useful? Because it does not really look
like it cleans up anything as-is.
It doesn't cleanup per-se, but it allows us to use the SCSI result
accessor functions to set the final result.
Without it we'll have to construct the result as a numeric value
within ql_pcmd(), and then set that value as a result to the SCSI
command in the caller.
Cheers,
Hannes
--
Dr. Hannes Reinecke Kernel Storage Architect
hare@xxxxxxx +49 911 74053 688
SUSE Software Solutions GmbH, Maxfeldstr. 5, 90409 Nürnberg
HRB 36809 (AG Nürnberg), Geschäftsführer: Felix Imendörffer
