On 4/26/21 5:26 PM, Christoph Hellwig wrote: > On Fri, Apr 23, 2021 at 01:39:24PM +0200, Hannes Reinecke wrote: >> Make ql_pcmd() a void function and set the SCSI result directly. >> >> Signed-off-by: Hannes Reinecke <hare@xxxxxxx> >> --- >> drivers/scsi/qlogicfas408.c | 75 ++++++++++++++++++++++++------------- >> 1 file changed, 49 insertions(+), 26 deletions(-) > > Can you explain why this is useful? Because it does not really look > like it cleans up anything as-is. > Hmm. I needed it for the entire patchset (splitting up host_byte and status_byte in two distinct values), but it might well be pointless here. Will be checking it and dropping if not required. Cheers, Hannes -- Dr. Hannes Reinecke Kernel Storage Architect hare@xxxxxxx +49 911 74053 688 SUSE Software Solutions Germany GmbH, 90409 Nürnberg GF: F. Imendörffer, HRB 36809 (AG Nürnberg)
