On Fri, 2021-01-22 at 16:45 +0000, Don.Brace@xxxxxxxxxxxxx wrote:
>
> > @@ static int pqi_ctrl_init_resume(struct pqi_ctrl_info *ctrl_info)
> >
> > pqi_start_heartbeat_timer(ctrl_info);
> >
> > + if (ctrl_info->enable_r5_writes || ctrl_info-
> > > enable_r6_writes) {
> > + rc =
> > pqi_get_advanced_raid_bypass_config(ctrl_info);
> > + if (rc) {
> > + dev_err(&ctrl_info->pci_dev->dev,
> > + "error obtaining advanced RAID
> > bypass
> > configuration\n");
> > + return rc;
>
> Do you need to error out here ? Can't you simply unset the
> enable_rX_writes feature?
>
> Don: If the call to pqi_get_advanced_raid_bypass_config fails, then
> there most likely be some serious issues. So we abandon the
> initialization process.
Ok, understood. A reader who isn't fully familiar with the HW
properties (like myself) may think that "advanced_raid_bypass"
is an optional performance-related feature and that the controller
could be operational without it. If that's not the case, fine.
Martin
