-----Original Message----- From: Martin Wilck [mailto:mwilck@xxxxxxxx] Subject: Re: [PATCH V3 06/25] smartpqi: add support for BMIC sense feature cmd and feature bits In general: This patch contains a lot of whitespace, indentation, and minor comment formatting changes which should rather go into a separate patch IMHO. This one is big enough without them. Don: Moved formatting HUNKs to smartpqi-align-code-with-oob-driver. Further remarks below. > @@ static int pqi_ctrl_init_resume(struct pqi_ctrl_info *ctrl_info) > > pqi_start_heartbeat_timer(ctrl_info); > > + if (ctrl_info->enable_r5_writes || ctrl_info- > >enable_r6_writes) { > + rc = pqi_get_advanced_raid_bypass_config(ctrl_info); > + if (rc) { > + dev_err(&ctrl_info->pci_dev->dev, > + "error obtaining advanced RAID bypass > configuration\n"); > + return rc; Do you need to error out here ? Can't you simply unset the enable_rX_writes feature? Don: If the call to pqi_get_advanced_raid_bypass_config fails, then there most likely be some serious issues. So we abandon the initialization process. Regards Martin
