This fixes an oops during driver load time.
mptsas_probe calls mpt_attach(over in mptbase.c). Inside that
call, we read some manufacturing config pages to setup some
defaults. While reading the config pages, the firmware doesn't
complete the reply in time, and we have a timeout. The timeout
results in hardreset handler being called. The hardreset
handler calls all the fusion upper layer driver reset callback
handlers. The mptsas_ioc_reset function is the callback handler
in mptsas.c. In summary, mptsas_ioc_reset is getting called
before scsi_host_alloc is called, and the pointer ioc->sh is
NULL, as well as the hostdata.
Signed-off-by: Judith Lebzelter <judith@xxxxxxxx
---
Sorry I was not more descriptive. Here is the patch with Eric's
description as requested.
Index: linux-2.6.21-rc3/drivers/message/fusion/mptsas.c
===================================================================
--- linux-2.6.21-rc3.orig/drivers/message/fusion/mptsas.c
+++ linux-2.6.21-rc3/drivers/message/fusion/mptsas.c
@@ -815,7 +815,7 @@ mptsas_taskmgmt_complete(MPT_ADAPTER *io
static int
mptsas_ioc_reset(MPT_ADAPTER *ioc, int reset_phase)
{
- MPT_SCSI_HOST *hd = (MPT_SCSI_HOST *)ioc->sh->hostdata;
+ MPT_SCSI_HOST *hd;
struct mptsas_target_reset_event *target_reset_list, *n;
int rc;
@@ -827,7 +827,10 @@ mptsas_ioc_reset(MPT_ADAPTER *ioc, int r
if (reset_phase != MPT_IOC_POST_RESET)
goto out;
- if (!hd || !hd->ioc)
+ if (!ioc->sh || !ioc->sh->hostdata)
+ goto out;
+ hd = (MPT_SCSI_HOST *)ioc->sh->hostdata;
+ if (!hd->ioc)
goto out;
if (list_empty(&hd->target_reset_list))
-
To unsubscribe from this list: send the line "unsubscribe linux-scsi" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
