On Fri, Mar 09, 2007 at 03:22:13PM -0700, Moore, Eric wrote: > On Friday, March 09, 2007 2:23 PM, Christoph Hellwig wrote: > > > > This needs a much better explanation. Please show the codepath > > leading to this. > > > > > > I was working with Judith on this patch earlier this week, so this is > approved by LSI,,, ACK. > > This fix's an oops during driver load time. mptsas_probe calls > mpt_attach(over in mptbase.c). Inside that call, we read some > manufacturing config pages to setup some defaults. While reading the > config pages, the firmware doesn't complete the reply in time, and we > have a timeout. The timeout results in hardreset handler being called. > The hardreset handler calls all the fusion upper layer driver reset > callback handlers. The mptsas_ioc_reset function is the callback > handler in mptsas.c. So where I'm getting to, is mptsas_ioc_reset is > getting called before scsi_host_alloc is called, and the pointer ioc->sh > is NULL.,,, as well as the hostdata. Ok. Please put a reformulated version of the above statement as a comment above the checks, so that people don't rip it out again. - To unsubscribe from this list: send the line "unsubscribe linux-scsi" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
