On Fri, 2007-03-09 at 10:36 -0800, Greg KH wrote: > On Wed, Mar 07, 2007 at 07:50:14PM -0500, James Bottomley wrote: > > On Wed, 2007-03-07 at 11:16 -0800, Andrew Morton wrote: > > > Achim did reply: http://lkml.org/lkml/2007/2/23/138 > > > > Ah ... OK; sorry, I'm parochial ... if it didn't appear on linux-scsi, > > you can usually assume I haven't seen it. > > > > > So we don't know what the patch does, but it should be merged into > > > -stable > > > (and mainline, heaven forfend) > > > > Well ... I would, except what this patch does is to initialise the > > command sg_ranz field (for both 64 bit and 32 bit commands). If you > > look in the code just below the patch application at the > > > > if (scp->use_sg) { > > ... > > } else if (scp->request_bufflen) { > > ... > > } > > > > You'll find a line setting these parameters in each of the cases of the > > if statement. So the bug appears to be that there's a missing else > > clause to this if, which would initialise the zero transfer commands. > > Is that a correct analysis? > > Well, as no one has really responded to this thread about what the patch > really does, and it's not in even James's tree yet, I've dropped it from > -stable. > > If James does send it to Linus, I'll be glad to reconsider it at that > time. I found the correct explanation. It was actually given by the bug reporter a while ago. I've got the following in scsi-rc-fixes-2.6, which should be upstream track. James
Attachment:
0001-SCSI-gdth-fix-oops-in-gdth_copy_cmd.patch
Description: application/mbox
