Re: [stable] [patch 29/29] bug in gdth.c crashing machine

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On Wed, 2007-03-07 at 11:16 -0800, Andrew Morton wrote:
> Achim did reply:  http://lkml.org/lkml/2007/2/23/138

Ah ... OK; sorry, I'm parochial ... if it didn't appear on linux-scsi,
you can usually assume I haven't seen it.

> So we don't know what the patch does, but it should be merged into
> -stable
> (and mainline, heaven forfend)

Well ... I would, except what this patch does is to initialise the
command sg_ranz field (for both 64 bit and 32 bit commands).  If you
look in the code just below the patch application at the 

if (scp->use_sg) {
...
} else if (scp->request_bufflen) {
...
}

You'll find a line setting these parameters in each of the cases of the
if statement.  So the bug appears to be that there's a missing else
clause to this if, which would initialise the zero transfer commands.
Is that a correct analysis?

James


-
To unsubscribe from this list: send the line "unsubscribe linux-scsi" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
[Index of Archives]     [SCSI Target Devel]     [Linux SCSI Target Infrastructure]     [Kernel Newbies]     [IDE]     [Security]     [Git]     [Netfilter]     [Bugtraq]     [Yosemite News]     [MIPS Linux]     [ARM Linux]     [Linux Security]     [Linux RAID]     [Linux ATA RAID]     [Linux IIO]     [Samba]     [Device Mapper]
  Powered by Linux