On Tue, 2020-12-08 at 09:05 +0000, Avri Altman wrote: > > " > > If fWriteBoosterBufferFlushDuringHibernate ==0, device will not > > flush > > WB, even if you keep device as "active mode" and LINK in hibernate > > state. > > OK, so what you are actually saying, is that since we are only > toggling this flag once per > link startup / recovery, in case of a failure, however rare - the > host may be still keep vcc on > for nothing, as the device will do nothing in that extra wake time. > Right? > again, this is a BUG, BUG... Bug is a Bug, doesn't matter it is rare or not rare. Tell me why we retry three times in ufshcd_query_flag_retry() in case of failure? > But every time ufshcd_wb_need_flush() is called we are reading some > other flags/attributes? > What about them? Why not protecting them as well? > did you read ufshcd_wb_need_flush() fully? they have been properly protected. > Sorry - the whole idea doesn't make any sense to me. > Thanks very much for sharing your opinion, I am very happy to hear your opinion. Because you don't believe this is a bug, I will ask other UFS guys to review, let Martin make the last decision. Thanks agaion for your review. Bean
