> > According to the JEDEC UFS 3.1 Spec, If > fWriteBoosterBufferFlushDuringHibernate > is set to one, the device flushes the WriteBooster Buffer data automatically > whenever the link enters the hibernate (HIBERN8) state. While the flushing > operation is in progress, the device should be kept in Active power mode. > Currently, we set this flag during the UFSHCD probe stage, but we didn't deal > with its programming failure. Even this failure is less likely to occur, but > still it is possible. > This patch is to add checkup of fWriteBoosterBufferFlushDuringHibernate > setting, > keep the device as "active power mode" only when this flag be successfully > set > to 1. > > Fixes: 51dd905bd2f6 ("scsi: ufs: Fix WriteBooster flush during runtime > suspend") > Signed-off-by: Bean Huo <beanhuo@xxxxxxxxxx> You've added the fixes tag, but my previous comment is still unanswered: you are adding protection to a single device management command. Why this command in particular? What makes it so special that it needs this extra care? Thanks, Avri