> On Thu, 22 Feb 2007 10:51:23 -0600 "Mike Miller (OS Dev)" <mikem@xxxxxxxxxxxxxxxxxxxxxxx> wrote:
> On Wed, Feb 21, 2007 at 07:14:27PM -0800, Andrew Morton wrote:
> > On Wed, 21 Feb 2007 15:10:39 -0600 "Mike Miller (OS Dev)" <mikem@xxxxxxxxxxxxxxxxxxxxxxx> wrote:
> >
> > > Patch 1/2
> > > + if (total_size == 0xFFFFFFFF) {
> >
> > I seem to remember having already questioned this. total_size is sector_t, which
> > can be either 32-bit or 64-bit. Are you sure that comparison works as
> > intended in both cases?
> >
> >
> > > + if(total_size == 0xFFFFFFFF) {
> > > cciss_read_capacity_16(cntl_num, i, 0,
> > > &total_size, &block_size);
> > > hba[cntl_num]->cciss_read = CCISS_READ_16;
> >
> > Here too.
> It has worked in all of the configs I've tested. Should I change it from sector_t to a
> __64? I have not tested all possible configs.
>
I'd suggest using -1: that just works.
-
To unsubscribe from this list: send the line "unsubscribe linux-scsi" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
