Re: [PATCH v3 0/5] Introduce a new helper marco DEFINE_SHOW_STORE_ATTRIBUTE at seq_file.c

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



Hi , Alan

On 2020/11/3 21:45, Alan Stern wrote:
On Tue, Nov 03, 2020 at 02:36:44PM +0100, Greg KH wrote:
On Tue, Nov 03, 2020 at 08:29:39PM +0800, Luo Jiaxing wrote:
We already own DEFINE_SHOW_ATTRIBUTE() helper macro for defining attribute
for read-only file, but we found many of drivers also want a helper macro
for read-write file too.

So we add this macro to help decrease code duplication.

---
  v1->v2:
         1.Rename DEFINE_STORE_ATTRIBUTE() to DEFINE_SHOW_STORE_ATTRIBUTE().
  v2->v3:
         1.Fixed some spelling mistakes in commit.
         2.Revised resumes are added for easy tracing.
You forgot to address Al Viro's review comments :(
You also might want to fix the type in the Subject line ("marco" instead
of "macro").


I'm sorry for such an obvious spelling error. Thanks for pointing out and it will be fixed in v4.


Jiaxing



Alan Stern

.





[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
[Index of Archives]     [SCSI Target Devel]     [Linux SCSI Target Infrastructure]     [Kernel Newbies]     [IDE]     [Security]     [Git]     [Netfilter]     [Bugtraq]     [Yosemite News]     [MIPS Linux]     [ARM Linux]     [Linux Security]     [Linux RAID]     [Linux ATA RAID]     [Linux IIO]     [Samba]     [Device Mapper]

  Powered by Linux