On Tue, Nov 03, 2020 at 02:36:44PM +0100, Greg KH wrote:
> On Tue, Nov 03, 2020 at 08:29:39PM +0800, Luo Jiaxing wrote:
> > We already own DEFINE_SHOW_ATTRIBUTE() helper macro for defining attribute
> > for read-only file, but we found many of drivers also want a helper macro
> > for read-write file too.
> >
> > So we add this macro to help decrease code duplication.
> >
> > ---
> > v1->v2:
> > 1.Rename DEFINE_STORE_ATTRIBUTE() to DEFINE_SHOW_STORE_ATTRIBUTE().
> > v2->v3:
> > 1.Fixed some spelling mistakes in commit.
> > 2.Revised resumes are added for easy tracing.
>
> You forgot to address Al Viro's review comments :(
You also might want to fix the type in the Subject line ("marco" instead
of "macro").
Alan Stern
