HI Mike,
Thanks for the review.
> +/*
> + * Sets port_state to Marginal/Online.
> + * On Marginal it Sets no retries on abort in scmd->state for all
> + * outstanding io of all the scsi_devs
> + * This only allows ONLINE->MARGINAL and MARGINAL->ONLINE
The above comments are not needed since not counting comments the code is
almost the same number of lines as the comments. Plus the comments below say
the same thing. And the functions/fields/variables you are using below are
pretty clear in what they are doing.
[Munendra] Agreed.
> + if (rport->port_state == FC_PORTSTATE_ONLINE) {
> + rport->port_state = port_state;
> + scsi_target_chg_noretries_abort(&rport->dev, 1);
> + }
Should this return a failure if port_state is not online?
[Muneendra]Agreed. Thanks for pointing it .I will add these changes in my
next version.
Regards,
Muneendra.
Attachment:
smime.p7s
Description: S/MIME Cryptographic Signature
