This patch adds a support to prevent retries of all the io's after an abort succeeds on a particular device when transport connectivity to the device is encountering intermittent errors. Intermittent connectivity is a condition that can be detected by transport fabric notifications. A service can monitor the ELS notifications and take action on all the outstanding io's of a scsi device at that instant. This feature is intended to be used when the device is part of a multipath environment. When the service detects the poor connectivity, the multipath path can be placed in a marginal path group and ignored further io operations. After placing a path in the marginal path group,the daemon sets the port_state to Marginal which sets bit in scmd->state for all the io's on that particular device with the new sysfs interface provided in this patch.This prevent retries of all the io's if an io hits a scsi timeout which inturn issues an abort. On Abort succeeds on a marginal path the io will be immediately retried on another active path.On abort fails then the things escalates to existing target reset sg interface recovery process. Below is the interface provided to set the port state to Marginal and Online. echo "Marginal" >> /sys/class/fc_remote_ports/rport-X\:Y-Z/port_state echo "Online" >> /sys/class/fc_remote_ports/rport-X\:Y-Z/port_state The patches were cut against 5.10/scsi-queue tree --- v3: Removed the port_state from starget attributes. Enabled the store functionality for port_state under remote port Added a new argument to scsi_cmd to fc_remote_port_chkready Used the existing scsi command iterators scsi_host_busy_iter. Rearranged the patches Added new patches to add new argument for fc_remote_port_chkready v2: Added new error code DID_TRANSPORT_MARGINAL to handle marginal errors. Added a new rport_state FC_PORTSTATE_MARGINAL and also added a new sysfs interface port_state to set the port_state to marginal. Added the support in lpfc to handle the marginal state. Muneendra (17): scsi: Added a new definition in scsi_cmnd.h scsi: Added a new error code in scsi.h scsi: No retries on abort success scsi: Added routine to set/clear SCMD_NORETRIES_ABORT bit for outstanding io on scsi_dev scsi_transport_fc: Added a new rport state FC_PORTSTATE_MARGINAL scsi_transport_fc: Added store fucntionality to set the rport port_state using sysfs scsi:lpfc: Added changes to fc_remote_port_chkready scsi:qla2xx: Added changes to fc_remote_port_chkready scsi:qedf: Added changes to fc_remote_port_chkready scsi:libfc: Added changes to fc_remote_port_chkready scsi:ibmvfc: Added changes to fc_remote_port_chkready scsi:fnic: Added changes to fc_remote_port_chkready scsi:bnx2fc: Added changes to fc_remote_port_chkready scsi:csio: Added changes to fc_remote_port_chkready scsi:bfa: Added changes to fc_remote_port_chkready scsi:zfcp: Added changes to fc_remote_port_chkready scsi:mpt: Added changes to fc_remote_port_chkready drivers/message/fusion/mptfc.c | 6 +- drivers/s390/scsi/zfcp_scsi.c | 2 +- drivers/scsi/bfa/bfad_im.c | 4 +- drivers/scsi/bnx2fc/bnx2fc_els.c | 2 +- drivers/scsi/bnx2fc/bnx2fc_io.c | 2 +- drivers/scsi/csiostor/csio_scsi.c | 6 +- drivers/scsi/fnic/fnic_main.c | 2 +- drivers/scsi/fnic/fnic_scsi.c | 6 +- drivers/scsi/ibmvscsi/ibmvfc.c | 28 +++++-- drivers/scsi/libfc/fc_fcp.c | 4 +- drivers/scsi/lpfc/lpfc_scsi.c | 4 +- drivers/scsi/qedf/qedf_els.c | 2 +- drivers/scsi/qedf/qedf_io.c | 4 +- drivers/scsi/qedf/qedf_main.c | 2 +- drivers/scsi/qla2xxx/qla_os.c | 6 +- drivers/scsi/scsi_error.c | 75 ++++++++++++++++++ drivers/scsi/scsi_lib.c | 2 + drivers/scsi/scsi_priv.h | 2 + drivers/scsi/scsi_transport_fc.c | 125 +++++++++++++++++++++++++----- include/scsi/scsi.h | 1 + include/scsi/scsi_cmnd.h | 3 + include/scsi/scsi_transport_fc.h | 26 ++++++- 22 files changed, 264 insertions(+), 50 deletions(-) -- 2.26.2
Attachment:
smime.p7s
Description: S/MIME Cryptographic Signature