RE: [PATCH v2 7/8] scsi_transport_fc: Added a new sysfs attribute port_state

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



Hi Hannes,


>> -
>> +	SETUP_PRIVATE_STARGET_ATTRIBUTE_RW(port_state);
>>   	BUG_ON(count > FC_STARGET_NUM_ATTRS);
>>
>>   	i->starget_attrs[count] = NULL;

>Why did you move it to be a 'starget' attribute?
>I would have thought it should be an 'rport' attribute, seeing that it's
>intrinsic to the fc transport class.
>>[Muneendra] Correct me if my understanding is wrong.
>>You want this to be part of /sys/class/fc_remote_ports/
>>rport-X\:Y-Z/port_state instead of
>>/sys/class/fc_transport/targetX\:Y\:Z/port_state

Under rport we already have an attribute of port_state which is currently
used to show the port_state.
/sys/class/fc_remote_ports/ rport-X\:Y-Z/port_state

We can add the store functionality to the same to set the port_state.
Is this  approach fine ?


Regards,
Muneendra.

Regards,
Muneendra.

Attachment: smime.p7s
Description: S/MIME Cryptographic Signature


[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
[Index of Archives]     [SCSI Target Devel]     [Linux SCSI Target Infrastructure]     [Kernel Newbies]     [IDE]     [Security]     [Git]     [Netfilter]     [Bugtraq]     [Yosemite News]     [MIPS Linux]     [ARM Linux]     [Linux Security]     [Linux RAID]     [Linux ATA RAID]     [Linux IIO]     [Samba]     [Device Mapper]

  Powered by Linux