Re: [PATCH] scsi: snic: Remove unnecessary condition to simplify the code

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

To: Jing Xiangfeng <jingxiangfeng@xxxxxxxxxx>
Subject: Re: [PATCH] scsi: snic: Remove unnecessary condition to simplify the code
From: "Martin K. Petersen" <martin.petersen@xxxxxxxxxx>
Date: Fri, 02 Oct 2020 21:15:02 -0400
Cc: <kartilak@xxxxxxxxx>, <sebaddel@xxxxxxxxx>, <jejb@xxxxxxxxxxxxx>, <martin.petersen@xxxxxxxxxx>, <linux-scsi@xxxxxxxxxxxxxxx>, <linux-kernel@xxxxxxxxxxxxxxx>
In-reply-to: <20200925060754.156599-1-jingxiangfeng@huawei.com> (Jing Xiangfeng's message of "Fri, 25 Sep 2020 14:07:54 +0800")
Organization: Oracle Corporation

Jing,

> ret is always zero or an error in this code path. So the assignment to
> ret is redundant, and the code jumping to a label is unneed.
> Let's remove them to simplify the code. No functional changes.

Applied to 5.10/scsi-staging, thanks!

-- 
Martin K. Petersen	Oracle Linux Engineering

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

References:
- [PATCH] scsi: snic: Remove unnecessary condition to simplify the code
  - From: Jing Xiangfeng

Prev by Date: Re: [PATCH] fnic: to not call 'scsi_done()' for unhandled commands
Next by Date: Re: [PATCH] scsi: fnic: Fix inconsistent of format with argument type in fnic_debugfs.c
Previous by thread: RE: [PATCH] scsi: snic: Remove unnecessary condition to simplify the code
Next by thread: Re: [PATCH] scsi: snic: Remove unnecessary condition to simplify the code
Index(es):
- Date
- Thread

[Index of Archives] [SCSI Target Devel] [Linux SCSI Target Infrastructure] [Kernel Newbies] [IDE] [Security] [Git] [Netfilter] [Bugtraq] [Yosemite News] [MIPS Linux] [ARM Linux] [Linux Security] [Linux RAID] [Linux ATA RAID] [Linux IIO] [Samba] [Device Mapper]

Powered by Linux