Looks good to me. Signed off by: Karan Tilak Kumar <kartilak@xxxxxxxxx> Regards, Karan -----Original Message----- From: Jing Xiangfeng <jingxiangfeng@xxxxxxxxxx> Sent: Thursday, September 24, 2020 11:08 PM To: Karan Tilak Kumar (kartilak) <kartilak@xxxxxxxxx>; Sesidhar Baddela (sebaddel) <sebaddel@xxxxxxxxx>; jejb@xxxxxxxxxxxxx; martin.petersen@xxxxxxxxxx Cc: linux-scsi@xxxxxxxxxxxxxxx; linux-kernel@xxxxxxxxxxxxxxx; jingxiangfeng@xxxxxxxxxx Subject: [PATCH] scsi: snic: Remove unnecessary condition to simplify the code ret is always zero or an error in this code path. So the assignment to ret is redundant, and the code jumping to a label is unneed. Let's remove them to simplify the code. No functional changes. Signed-off-by: Jing Xiangfeng <jingxiangfeng@xxxxxxxxxx> --- drivers/scsi/snic/snic_scsi.c | 4 ---- 1 file changed, 4 deletions(-) diff --git a/drivers/scsi/snic/snic_scsi.c b/drivers/scsi/snic/snic_scsi.c index b3650c989ed4..0c2f31b8ea05 100644 --- a/drivers/scsi/snic/snic_scsi.c +++ b/drivers/scsi/snic/snic_scsi.c @@ -1387,10 +1387,6 @@ snic_issue_tm_req(struct snic *snic, } ret = snic_queue_itmf_req(snic, tmreq, sc, tmf, req_id); - if (ret) - goto tmreq_err; - - ret = 0; tmreq_err: if (ret) { -- 2.17.1