On 9/28/20 12:50 AM, Nilesh Javali wrote:
+ if (rval == QLA_SUCCESS) {
+ __be32 *q = (__be32 *)&ha->plogi_els_payld.fl_csp;
+
+ bp = (uint32_t *)ha->init_cb;
+ cpu_to_be32_array(q, bp, sz / 4);
+ ha->flags.plogi_template_valid = 1;
+ } else {
+ ql_dbg(ql_dbg_init, vha, 0x00d1,
+ "PLOGI ELS param read fail.\n");
+ }
How about making this more readable as following
if (rval != QLA_SUCCESS) {
ql_dbg(ql_dbg_ini, vha, 0x00d1,
"PLOGI ELS parameter read failed.\n");
return;
}
*q = (__be32 *)&ha->plogi_els_payld.fl_csp;
bp = (uint32_t *)ha->init_cb;
cpu_to_be32_array(q, bp, sz / 4);
ha->flags.plogi_template_valid = 1;
Otherwise looks good
Reviewed-by: Himanshu Madhani <himanshu.madhani@xxxxxxxxxx>
--
Himanshu Madhani Oracle Linux Engineering
