Re: [PATCH] qed (qed_int.c) disable "MFW indication via attention" SPAM every 5 minutes

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



From: Laurence Oberman <loberman@xxxxxxxxxx>
Date: Tue, 14 Jul 2020 09:50:29 -0400

> This is likely firmware causing this but its starting to annoy customers.
> Change the message level to verbose to prevent the spam.
> Note that this seems to only show up with ISCSI enabled on the HBA via the 
> qedi driver.
> 
> Signed-off-by: Laurence Oberman <loberman@xxxxxxxxxx>

Please... I asked you to look at recent changes to this driver and use
a Subject line consistent with those changes.

And if I do:

	git shortlog v5.6.. -- drivers/net/ethernet/qlogic/qed

I see commit header lines using "qed: " as the subsystem prefix.

So I have to ask, where in recent changes to this driver did you see
examples of people explicitly mentioning "(qed_int.c)" or other file
names?  Where did you see other changes not having a colon character
separating the subsystem prefix from the one-line description?

Please, format this properly:

	[PATCH net] qed: Disable "MFW indictation via attention" SPAM every 5 minutes

For the future, just look at what other developers are doing rather than
inventing your own formatting.

Thank you.




[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
[Index of Archives]     [SCSI Target Devel]     [Linux SCSI Target Infrastructure]     [Kernel Newbies]     [IDE]     [Security]     [Git]     [Netfilter]     [Bugtraq]     [Yosemite News]     [MIPS Linux]     [ARM Linux]     [Linux Security]     [Linux RAID]     [Linux ATA RAID]     [Linux IIO]     [Samba]     [Device Mapper]

  Powered by Linux