On Wed, Jan 24 2007, FUJITA Tomonori wrote: > From: Jens Axboe <jens.axboe@xxxxxxxxxx> > Subject: Re: [PATCH] add bsg queue resize > Date: Tue, 23 Jan 2007 16:23:49 +0100 > > > On Tue, Jan 23 2007, Jens Axboe wrote: > > > On Sat, Jan 20 2007, FUJITA Tomonori wrote: > > > > This enables bsg to resize the queue depth via > > > > SG_SET_COMMAND_Q. bsg_command structures are allocated via mempool > > > > because the previous way to use contiguous memory makes it difficult > > > > to resize the queue depth when a bsg_device has outstanding commands. > > > > > > Overall the patch looks fine. I don't think we need a mempool though, > > > and allocations could just use GFP_USER from the user invoked queuing > > > paths. Just make it GFP_USER, we can always extend the > > > bsg_alloc_command() to take a gfp_t argument as well If you get rid of > > > the mempool, then resizing is simply just adjusting bd->max_queue. > > > > Like so. > > Thanks. I thought that pre-allocating bsg_command structures would be > nice. But it doesn't matter much for me. Probably not very useful in the end, we need to allocate some other structures for IO anyway. > One minor comment is that we could simplify __bsg_alloc_command > failpath a bit? Yep, applied. Another thing that needs cleaning up for the allocation is the whole bsg_io_schedule() stuff. -- Jens Axboe - To unsubscribe from this list: send the line "unsubscribe linux-scsi" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
