On Sat, Jan 20 2007, FUJITA Tomonori wrote: > This enables bsg to resize the queue depth via > SG_SET_COMMAND_Q. bsg_command structures are allocated via mempool > because the previous way to use contiguous memory makes it difficult > to resize the queue depth when a bsg_device has outstanding commands. Overall the patch looks fine. I don't think we need a mempool though, and allocations could just use GFP_USER from the user invoked queuing paths. Just make it GFP_USER, we can always extend the bsg_alloc_command() to take a gfp_t argument as well If you get rid of the mempool, then resizing is simply just adjusting bd->max_queue. -- Jens Axboe - To unsubscribe from this list: send the line "unsubscribe linux-scsi" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
