Re: [PATCH V2 1/3] pm80xx : Support for get phy profile functionality.

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



Hi Deepak,

Thank you for the patch! Perhaps something to improve:

[auto build test WARNING on mkp-scsi/for-next]
[also build test WARNING on scsi/for-next v5.8-rc2 next-20200624]
[If your patch is applied to the wrong git tree, kindly drop us a note.
And when submitting patch, we suggest to use  as documented in
https://git-scm.com/docs/git-format-patch]

url:    https://github.com/0day-ci/linux/commits/Deepak-Ukey/pm80xx-Updates-for-the-driver-version-0-1-39/20200624-195528
base:   https://git.kernel.org/pub/scm/linux/kernel/git/mkp/scsi.git for-next
config: x86_64-allyesconfig (attached as .config)
compiler: clang version 11.0.0 (https://github.com/llvm/llvm-project 1d4c87335d5236ea1f35937e1014980ba961ae34)
reproduce (this is a W=1 build):
        wget https://raw.githubusercontent.com/intel/lkp-tests/master/sbin/make.cross -O ~/bin/make.cross
        chmod +x ~/bin/make.cross
        # install x86_64 cross compiling tool for clang build
        # apt-get install binutils-x86-64-linux-gnu
        # save the attached .config to linux build tree
        COMPILER_INSTALL_PATH=$HOME/0day COMPILER=clang make.cross ARCH=x86_64 

If you fix the issue, kindly add following tag as appropriate
Reported-by: kernel test robot <lkp@xxxxxxxxx>

All warnings (new ones prefixed by >>):

   drivers/scsi/pm8001/pm80xx_hwi.c:69:6: warning: no previous prototype for function 'pm80xx_pci_mem_copy' [-Wmissing-prototypes]
   void pm80xx_pci_mem_copy(struct pm8001_hba_info  *pm8001_ha, u32 soffset,
        ^
   drivers/scsi/pm8001/pm80xx_hwi.c:69:1: note: declare 'static' if the function is not intended to be used outside of this translation unit
   void pm80xx_pci_mem_copy(struct pm8001_hba_info  *pm8001_ha, u32 soffset,
   ^
   static 
>> drivers/scsi/pm8001/pm80xx_hwi.c:5064:5: warning: no previous prototype for function 'pm8001_chip_get_phy_profile' [-Wmissing-prototypes]
   int pm8001_chip_get_phy_profile(struct pm8001_hba_info *pm8001_ha, int phy_id,
       ^
   drivers/scsi/pm8001/pm80xx_hwi.c:5064:1: note: declare 'static' if the function is not intended to be used outside of this translation unit
   int pm8001_chip_get_phy_profile(struct pm8001_hba_info *pm8001_ha, int phy_id,
   ^
   static 
   drivers/scsi/pm8001/pm80xx_hwi.c:5094:6: warning: no previous prototype for function 'mpi_set_phy_profile_req' [-Wmissing-prototypes]
   void mpi_set_phy_profile_req(struct pm8001_hba_info *pm8001_ha,
        ^
   drivers/scsi/pm8001/pm80xx_hwi.c:5094:1: note: declare 'static' if the function is not intended to be used outside of this translation unit
   void mpi_set_phy_profile_req(struct pm8001_hba_info *pm8001_ha,
   ^
   static 
   3 warnings generated.

vim +/pm8001_chip_get_phy_profile +5064 drivers/scsi/pm8001/pm80xx_hwi.c

  5063	
> 5064	int pm8001_chip_get_phy_profile(struct pm8001_hba_info *pm8001_ha, int phy_id,
  5065			int page_code, struct completion *comp, void *buf)
  5066	{
  5067		u32 tag;
  5068		struct get_phy_profile_req payload;
  5069		struct inbound_queue_table *circularQ;
  5070		struct pm8001_ccb_info *ccb;
  5071		int rc, ppc_phyid;
  5072		u32 opc = OPC_INB_GET_PHY_PROFILE;
  5073	
  5074		memset(&payload, 0, sizeof(payload));
  5075	
  5076		rc = pm8001_tag_alloc(pm8001_ha, &tag);
  5077		if (rc)
  5078			PM8001_FAIL_DBG(pm8001_ha, pm8001_printk("Invalid tag\n"));
  5079	
  5080		ccb = &pm8001_ha->ccb_info[tag];
  5081		ccb->completion = comp;
  5082		ccb->resp_buf = buf;
  5083		circularQ = &pm8001_ha->inbnd_q_tbl[0];
  5084	
  5085		payload.tag = cpu_to_le32(tag);
  5086		ppc_phyid = (page_code & 0xFF)  << 8 | (phy_id & 0xFF);
  5087		payload.ppc_phyid = cpu_to_le32(ppc_phyid);
  5088	
  5089		pm8001_mpi_build_cmd(pm8001_ha, circularQ, opc, &payload,
  5090				sizeof(payload), 0);
  5091		return rc;
  5092	}
  5093	

---
0-DAY CI Kernel Test Service, Intel Corporation
https://lists.01.org/hyperkitty/list/kbuild-all@xxxxxxxxxxxx

Attachment: .config.gz
Description: application/gzip


[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
[Index of Archives]     [SCSI Target Devel]     [Linux SCSI Target Infrastructure]     [Kernel Newbies]     [IDE]     [Security]     [Git]     [Netfilter]     [Bugtraq]     [Yosemite News]     [MIPS Linux]     [ARM Linux]     [Linux Security]     [Linux RAID]     [Linux ATA RAID]     [Linux IIO]     [Samba]     [Device Mapper]

  Powered by Linux