Hi Deepak, Thank you for the patch! Perhaps something to improve: [auto build test WARNING on mkp-scsi/for-next] [also build test WARNING on scsi/for-next v5.8-rc2 next-20200624] [If your patch is applied to the wrong git tree, kindly drop us a note. And when submitting patch, we suggest to use as documented in https://git-scm.com/docs/git-format-patch] url: https://github.com/0day-ci/linux/commits/Deepak-Ukey/pm80xx-Updates-for-the-driver-version-0-1-39/20200624-195528 base: https://git.kernel.org/pub/scm/linux/kernel/git/mkp/scsi.git for-next config: x86_64-rhel-7.6 (attached as .config) compiler: gcc-9 (Debian 9.3.0-13) 9.3.0 reproduce (this is a W=1 build): # save the attached .config to linux build tree make W=1 ARCH=x86_64 If you fix the issue, kindly add following tag as appropriate Reported-by: kernel test robot <lkp@xxxxxxxxx> All warnings (new ones prefixed by >>): >> drivers/scsi/pm8001/pm80xx_hwi.c:52:7: warning: no previous prototype for 'pm8001_queue_phyup' [-Wmissing-prototypes] 52 | void pm8001_queue_phyup(struct pm8001_hba_info *pm8001_ha, int phy_id) | ^~~~~~~~~~~~~~~~~~ drivers/scsi/pm8001/pm80xx_hwi.c:135:6: warning: no previous prototype for 'pm80xx_pci_mem_copy' [-Wmissing-prototypes] 135 | void pm80xx_pci_mem_copy(struct pm8001_hba_info *pm8001_ha, u32 soffset, | ^~~~~~~~~~~~~~~~~~~ drivers/scsi/pm8001/pm80xx_hwi.c:5157:5: warning: no previous prototype for 'pm8001_chip_get_phy_profile' [-Wmissing-prototypes] 5157 | int pm8001_chip_get_phy_profile(struct pm8001_hba_info *pm8001_ha, int phy_id, | ^~~~~~~~~~~~~~~~~~~~~~~~~~~ drivers/scsi/pm8001/pm80xx_hwi.c:5187:6: warning: no previous prototype for 'mpi_set_phy_profile_req' [-Wmissing-prototypes] 5187 | void mpi_set_phy_profile_req(struct pm8001_hba_info *pm8001_ha, | ^~~~~~~~~~~~~~~~~~~~~~~ vim +/pm8001_queue_phyup +52 drivers/scsi/pm8001/pm80xx_hwi.c 48 49 static int pm80xx_chip_phy_ctl_req(struct pm8001_hba_info *pm8001_ha, 50 u32 phyId, u32 phy_op); 51 > 52 void pm8001_queue_phyup(struct pm8001_hba_info *pm8001_ha, int phy_id) 53 { 54 int i; 55 56 if (pm8001_ha->phy_head == -1) { 57 pm8001_ha->phy_head = pm8001_ha->phy_tail = 0; 58 } else { 59 /* If the phy id is already queued , discard the phy up */ 60 for (i = 0; i < pm8001_ha->chip->n_phy; i++) 61 if (pm8001_ha->phy_up[i] == phy_id) 62 return; 63 pm8001_ha->phy_tail = 64 (pm8001_ha->phy_tail + 1) % PM8001_MAX_PHYS; 65 } 66 pm8001_ha->phy_up[pm8001_ha->phy_tail] = phy_id; 67 } 68 --- 0-DAY CI Kernel Test Service, Intel Corporation https://lists.01.org/hyperkitty/list/kbuild-all@xxxxxxxxxxxx
Attachment:
.config.gz
Description: application/gzip
