On 6/18/20 10:14 AM, Daniel Wagner wrote:
On Wed, Jun 17, 2020 at 10:48:10AM +0200, Hannes Reinecke wrote:
On 6/17/20 10:34 AM, Hannes Reinecke wrote:
On 6/17/20 10:21 AM, Daniel Wagner wrote:
On Tue, Jun 16, 2020 at 02:18:18PM +0200, Hannes Reinecke wrote:
Long overdue. No functional change.
Did you test if compiler generates the same output? I don't think anyone
wants to review this patch :)
Hmm. No. Lemme check what happens...
Phew. Just checked, and the disassembly is indeed identical.
I am not really convienced it is a good idea to reformat the whole
driver at this point. Sure, checkpatch.pl & friends will be more
happy with new changes. Though, in 10 years there were only 44
changes and I don't think there will be a lot more in the coming
years. Just my thoughts.
Says you.
6fa4468afcf73a3f53a70f0e76a63d0a03b641fc gdth: kill 'cmnd' argument from
gdth_execute()
652d47aa4b4fcc9422d99727671af178323f231f gdth: merge gdth_proc.c into gdth.c
aee96950cc505670d4befe9fb2f1faa0dfe179fb gdth: split off gdth_init_pci()
89d259c342c690d4110b04f3f21aa853f2e69ab7 gdth: convert TRACE macros to
dynamic debug
70526df12feaa74c6fd487561fd52ac93e89e025 gdth: drop statistics during
I/O submission
0e0c7414780dbfd86f19967f35481e3e99456551 gdth: replace blank printk()
statements with dev_xxx variants
db9e448aae664f4b702849d40fa7de563563f68e gdth: stop abusing ->request
pointer for completion
ac60bebd3a1d13a523e019440798f206e9cd83ce gdth: kill __gdth_execute()
4dded2800578c60e1c2b4dd6ee08b14bc9ef1181 gdth: do not use struct
scsi_cmnd as argument for bus reset
6c599cfd05580969e13bdada8c54c0a643aa56f5 gdth: reindent and whitespace
cleanup
As mentioned, the gdth driver is the only one using the scsi_host_dev
feature, which I'll be improving/updating with my reserved tags for SCSI
patchset.
And to avoid my eyes falling out everytime I need to look at the driver
I would very much prefer to have the reindent done.
Especially as it can be easily verified.
Cheers,
Hannes
--
Dr. Hannes Reinecke Teamlead Storage & Networking
hare@xxxxxxx +49 911 74053 688
SUSE Software Solutions GmbH, Maxfeldstr. 5, 90409 Nürnberg
HRB 36809 (AG Nürnberg), Geschäftsführer: Felix Imendörffer
