On Wed, Jun 17, 2020 at 10:48:10AM +0200, Hannes Reinecke wrote: > On 6/17/20 10:34 AM, Hannes Reinecke wrote: > > On 6/17/20 10:21 AM, Daniel Wagner wrote: > > > On Tue, Jun 16, 2020 at 02:18:18PM +0200, Hannes Reinecke wrote: > > > > Long overdue. No functional change. > > > > > > Did you test if compiler generates the same output? I don't think anyone > > > wants to review this patch :) > > > > > Hmm. No. Lemme check what happens... > > > Phew. Just checked, and the disassembly is indeed identical. I am not really convienced it is a good idea to reformat the whole driver at this point. Sure, checkpatch.pl & friends will be more happy with new changes. Though, in 10 years there were only 44 changes and I don't think there will be a lot more in the coming years. Just my thoughts.