Re: [PATCH RFC v7 02/12] blk-mq: rename blk_mq_update_tag_set_depth()

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On 11/06/2020 03:57, Ming Lei wrote:
On Thu, Jun 11, 2020 at 01:29:09AM +0800, John Garry wrote:
From: Hannes Reinecke <hare@xxxxxxx>

The function does not set the depth, but rather transitions from
shared to non-shared queues and vice versa.
So rename it to blk_mq_update_tag_set_shared() to better reflect
its purpose.

It is fine to rename it for me, however:

This patch claims to rename blk_mq_update_tag_set_shared(), but also
change blk_mq_init_bitmap_tags's signature.

I was going to update the commit message here, but forgot again...


So suggest to split this patch into two or add comment log on changing
blk_mq_init_bitmap_tags().

I think I'll just split into 2x commits.

Thanks,
John



[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
[Index of Archives]     [SCSI Target Devel]     [Linux SCSI Target Infrastructure]     [Kernel Newbies]     [IDE]     [Security]     [Git]     [Netfilter]     [Bugtraq]     [Yosemite News]     [MIPS Linux]     [ARM Linux]     [Linux Security]     [Linux RAID]     [Linux ATA RAID]     [Linux IIO]     [Samba]     [Device Mapper]

  Powered by Linux