On Thu, Jun 11, 2020 at 01:29:09AM +0800, John Garry wrote: > From: Hannes Reinecke <hare@xxxxxxx> > > The function does not set the depth, but rather transitions from > shared to non-shared queues and vice versa. > So rename it to blk_mq_update_tag_set_shared() to better reflect > its purpose. It is fine to rename it for me, however: This patch claims to rename blk_mq_update_tag_set_shared(), but also change blk_mq_init_bitmap_tags's signature. So suggest to split this patch into two or add comment log on changing blk_mq_init_bitmap_tags(). Thanks, Ming
