Re: [PATCH v4 09/11] qla2xxx: Change {RD,WRT}_REG_*() function names from upper case into lower case

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On 2020-05-11 00:40, Arun Easi wrote:
> On Sun, 26 Apr 2020, 8:03pm, Bart Van Assche wrote:
>> @@ -258,8 +258,8 @@ static inline void WRT_REG_DWORD(volatile __le32 __iomem *addr, u32 data)
>>   * The ISP2312 v2 chip cannot access the FLASH/GPIO registers via MMIO in an
>>   * 133Mhz slot.
>>   */
>> -#define RD_REG_WORD_PIO(addr)		(inw((unsigned long)addr))
>> -#define WRT_REG_WORD_PIO(addr, data)	(outw(data, (unsigned long)addr))
>> +#define rd_reg_word_PIO(addr)		(inw((unsigned long)addr))
>> +#define wrt_reg_word_PIO(addr, data)	(outw(data, (unsigned long)addr))
> 
> Why mix case for PIO? Might as well do it here too. Anyway,
> 
> Reviewed-by: Arun Easi <aeasi@xxxxxxxxxxx>

Hi Arun,

Please trim emails when replying. It was hard for me to find your reply.

Anyway, I will make the proposed change.

Thanks,

Bart.



[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
[Index of Archives]     [SCSI Target Devel]     [Linux SCSI Target Infrastructure]     [Kernel Newbies]     [IDE]     [Security]     [Git]     [Netfilter]     [Bugtraq]     [Yosemite News]     [MIPS Linux]     [ARM Linux]     [Linux Security]     [Linux RAID]     [Linux ATA RAID]     [Linux IIO]     [Samba]     [Device Mapper]

  Powered by Linux