On 2020-05-11 00:40, Arun Easi wrote: > On Sun, 26 Apr 2020, 8:03pm, Bart Van Assche wrote: >> @@ -258,8 +258,8 @@ static inline void WRT_REG_DWORD(volatile __le32 __iomem *addr, u32 data) >> * The ISP2312 v2 chip cannot access the FLASH/GPIO registers via MMIO in an >> * 133Mhz slot. >> */ >> -#define RD_REG_WORD_PIO(addr) (inw((unsigned long)addr)) >> -#define WRT_REG_WORD_PIO(addr, data) (outw(data, (unsigned long)addr)) >> +#define rd_reg_word_PIO(addr) (inw((unsigned long)addr)) >> +#define wrt_reg_word_PIO(addr, data) (outw(data, (unsigned long)addr)) > > Why mix case for PIO? Might as well do it here too. Anyway, > > Reviewed-by: Arun Easi <aeasi@xxxxxxxxxxx> Hi Arun, Please trim emails when replying. It was hard for me to find your reply. Anyway, I will make the proposed change. Thanks, Bart.