Re: [PATCH] ieee1394: sbp2: remove bogus "emulated" host flag

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On 15 Jan, Kristian Høgsberg wrote:
> On 1/14/07, Stefan Richter <stefanr@xxxxxxxxxxxxxxxxx> wrote:
>> There is no emulation going on here.
> ...
> 
>> -       .emulated                = 1,
> 
> Not sure what this flag does, but I copied it over to fw-sbp2.c.

There is a single use: Userspace application clients can look up the
value of this flag via the sg driver and can then come to whatever
conclusions.

> If it's bogus,

The flag was "half true" back in the times when sbp2 mangled a lot of
commands and responses to account for command sets behind the back of
the SCSI stack. That's not the case any more.

> I guess we should drop it from fw-sbp2.c too.

Yes. I merely didn't ready a patch because I currently want to
concentrate my SBP-2 related work on sbp2 and push relevant bits over to
fw-sbp2 some time later in one go, as far as you didn't do so already.
(I'll send a parallel fw-sbp2 patch too if something earthshaking comes
along.)
-- 
Stefan Richter
-=====-=-=== ---= -====
http://arcgraph.de/sr/

-
To unsubscribe from this list: send the line "unsubscribe linux-scsi" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
[Index of Archives]     [SCSI Target Devel]     [Linux SCSI Target Infrastructure]     [Kernel Newbies]     [IDE]     [Security]     [Git]     [Netfilter]     [Bugtraq]     [Yosemite News]     [MIPS Linux]     [ARM Linux]     [Linux Security]     [Linux RAID]     [Linux ATA RAID]     [Linux IIO]     [Samba]     [Device Mapper]
  Powered by Linux